Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): no style in blank cell #3231

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(sheets): no style in blank cell #3231

merged 1 commit into from
Aug 29, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Aug 28, 2024

close https://github.com/dream-num/univer-pro/issues/993
close https://github.com/dream-num/univer-pro/issues/2069

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review August 28, 2024 09:09
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 28, 2024
@Jocs Jocs requested a review from weird94 August 28, 2024 09:10
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.56%. Comparing base (84e8c89) to head (95a3fe4).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 4 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3231      +/-   ##
==========================================
- Coverage   28.62%   28.56%   -0.06%     
==========================================
  Files        2025     2022       -3     
  Lines      106979   106775     -204     
  Branches    23134    23102      -32     
==========================================
- Hits        30623    30503     -120     
+ Misses      76356    76272      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

@Jocs#1770 1、选中链接单元格清除内容(或delete删除)
2、单击选中该单元格直接输入内容
预期:编辑态下输入内容也显示为文本
表现:编辑态下输入新的内容仍显示链接的格式,退出后显示为文本
2024_8_29 14_26_23 commands.json
2024_8_29 14_26_23 video.webm

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Aug 29, 2024
@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Aug 29, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Aug 29, 2024
@Jocs Jocs merged commit e9360c4 into dev Aug 29, 2024
15 of 16 checks passed
@Jocs Jocs deleted the fix/cell-style branch August 29, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants