Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: telemetry.merge #3251

Merged
merged 6 commits into from
Sep 2, 2024
Merged

feat: telemetry.merge #3251

merged 6 commits into from
Sep 2, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Aug 30, 2024

close https://github.com/dream-num/univer-pro/issues/2313

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku force-pushed the feat/telemetry.merge branch 5 times, most recently from 0a315e0 to b350d75 Compare September 2, 2024 07:34
Copy link

github-actions bot commented Sep 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku marked this pull request as ready for review September 2, 2024 07:40
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0.45455% with 219 lines in your changes missing coverage. Please review.

Project coverage is 29.85%. Comparing base (f21ce50) to head (e2ab474).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...lers/render-controllers/sheet.render-controller.ts 0.00% 70 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 48 Missing ⚠️
...es/engine-render/src/basics/performance-monitor.ts 0.00% 46 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 23 Missing ⚠️
...ckages/telemetry/src/services/telemetry-service.ts 0.00% 12 Missing ⚠️
...heets-ui/src/services/selection/selection-layer.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 5 Missing ⚠️
packages/core/src/shared/tools.ts 0.00% 4 Missing ⚠️
...ervices/selection/base-selection-render.service.ts 0.00% 2 Missing ⚠️
...rc/components/sheets/extensions/sheet-extension.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3251      +/-   ##
==========================================
- Coverage   29.89%   29.85%   -0.05%     
==========================================
  Files        2036     2038       +2     
  Lines      109127   109277     +150     
  Branches    23749    23769      +20     
==========================================
  Hits        32622    32622              
- Misses      76505    76655     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

feat: add telemtry frompro

feat: get data from performanceMonitor
chore: move sum vp into sheet render controller

chore: move $ from scene to engine

chore: use ext uKey not constructor.name

chore: rm useless

chore: use ext uKey not constructor.name
chore: fix import & type check
@lumixraku lumixraku merged commit 8f01cf3 into dev Sep 2, 2024
9 checks passed
@lumixraku lumixraku deleted the feat/telemetry.merge branch September 2, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants