Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected cross viewport selection because it counts rowheader #3296

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Sep 3, 2024

close https://github.com/dream-num/univer-pro/issues/2304

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 3, 2024
@lumixraku lumixraku changed the title fix: scrolltimer accrose viewport fix: unexpected cross viewport selection because it counts rowheader Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 30.18%. Comparing base (5a91942) to head (b94e2db).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ervices/selection/base-selection-render.service.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/scroll-timer.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3296      +/-   ##
==========================================
- Coverage   30.18%   30.18%   -0.01%     
==========================================
  Files        2039     2039              
  Lines      109339   109347       +8     
  Branches    23778    23781       +3     
==========================================
  Hits        33004    33004              
- Misses      76335    76343       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/scrolltimer branch 3 times, most recently from b3202fd to 76a5e6e Compare September 3, 2024 08:06
Copy link

github-actions bot commented Sep 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 3, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 3, 2024
@lumixraku lumixraku merged commit ebde3da into dev Sep 3, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/scrolltimer branch September 3, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants