Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix uni menu #3338

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: fix uni menu #3338

merged 1 commit into from
Sep 5, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Sep 5, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit af63f7d into dev Sep 5, 2024
9 checks passed
@jikkai jikkai deleted the fix/uni-menu branch September 5, 2024 12:49
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.18%. Comparing base (c29fa22) to head (f6bbbf4).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...al/uniui/src/views/uni-toolbar/UniFloatToolbar.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3338   +/-   ##
=======================================
  Coverage   30.18%   30.18%           
=======================================
  Files        2112     2111    -1     
  Lines      109767   109854   +87     
  Branches    23870    23896   +26     
=======================================
+ Hits        33132    33161   +29     
- Misses      76635    76693   +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants