Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): init view model #3349

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(conditional-formatting): init view model #3349

merged 1 commit into from
Sep 6, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Sep 6, 2024

close https://github.com/dream-num/univer-pro/issues/2393

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound added qa:untested This PR is ready to be tested and removed qa:untested This PR is ready to be tested labels Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 30.20%. Comparing base (be7da80) to head (8529997).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3349      +/-   ##
==========================================
- Coverage   30.21%   30.20%   -0.01%     
==========================================
  Files        2112     2112              
  Lines      109977   109996      +19     
  Branches    23921    23923       +2     
==========================================
  Hits        33228    33228              
- Misses      76749    76768      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound removed the qa:untested This PR is ready to be tested label Sep 6, 2024
@Gggpound Gggpound merged commit ad145f2 into dev Sep 6, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-cf-0906-2 branch September 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants