Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add function leftb #3418

Merged
merged 6 commits into from
Sep 19, 2024
Merged

feat(formula): add function leftb #3418

merged 6 commits into from
Sep 19, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Sep 12, 2024

close #2573

The issue reported in #2610 has been fixed

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 12, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  53efa8c
info  For more information, see full report

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.70%. Comparing base (38b03fb) to head (53efa8c).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...s/engine-formula/src/functions/text/leftb/index.ts 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3418      +/-   ##
==========================================
+ Coverage   30.67%   30.70%   +0.02%     
==========================================
  Files        2156     2157       +1     
  Lines      113045   113092      +47     
  Branches    24777    24793      +16     
==========================================
+ Hits        34681    34726      +45     
- Misses      78364    78366       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review September 14, 2024 02:44
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Sep 14, 2024
@zhaolixin7
Copy link

@Dushusir 1、直接引用单元格和直接引用值结果不一致,引用单元格未报错
image
image
2、参数为true和false时结果未显示大写
image

@univer-bot
Copy link

univer-bot bot commented Sep 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir 1. The results of directly referencing the cell and directly referencing the value are inconsistent, and no error is reported for the referenced cell.
image
image
2. When the parameters are true and false, the result is not displayed in capital letters.
image

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 18, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 18, 2024
@Dushusir Dushusir merged commit b66e8ce into dev Sep 19, 2024
9 checks passed
@Dushusir Dushusir deleted the feat/formula-leftb branch September 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Text Formula LEFTB
3 participants