Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): wrong ime position after scroll #3457

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix(docs): wrong ime position after scroll #3457

merged 1 commit into from
Sep 14, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Sep 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  4795f13
info  For more information, see full report

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (0d437d3) to head (4795f13).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...docs/src/services/doc-selection-manager.service.ts 0.00% 18 Missing ⚠️
...services/selection/doc-selection-render.service.ts 0.00% 15 Missing ⚠️
...der-controllers/doc-selection-render.controller.ts 0.00% 5 Missing ⚠️
...ollers/render-controllers/doc.render-controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3457      +/-   ##
==========================================
+ Coverage   30.55%   30.59%   +0.04%     
==========================================
  Files        2156     2156              
  Lines      112881   112925      +44     
  Branches    24747    24762      +15     
==========================================
+ Hits        34486    34546      +60     
+ Misses      78395    78379      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review September 14, 2024 11:44
@Jocs Jocs merged commit 6e6b0b2 into dev Sep 14, 2024
13 checks passed
@Jocs Jocs deleted the fix/ime-position branch September 14, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants