Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set document #3521

Merged
merged 1 commit into from
Sep 21, 2024
Merged

feat: set document #3521

merged 1 commit into from
Sep 21, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Sep 21, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review September 21, 2024 11:04
@Jocs Jocs requested a review from jikkai as a code owner September 21, 2024 11:04
Copy link

Playwright test results

passed  3 passed
flaky  1 flaky

Details

stats  4 tests across 2 suites
duration  1 minute, 52 seconds
commit  1881297
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (61ee1cd) to head (1881297).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
packages/docs-ui/src/services/editor/editor.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3521   +/-   ##
=======================================
  Coverage   30.90%   30.90%           
=======================================
  Files        2161     2161           
  Lines      113497   113499    +2     
  Branches    24889    24891    +2     
=======================================
+ Hits        35078    35079    +1     
- Misses      78419    78420    +1     
Flag Coverage Δ
30.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs merged commit 5489ce8 into dev Sep 21, 2024
13 checks passed
@Jocs Jocs deleted the feat/set-document branch September 21, 2024 12:10
VicKun4937 pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants