Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): formula across subsheet #3583

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 25, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 6 seconds
commit  be3012d
info  For more information, see full report

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.85%. Comparing base (2fc56ff) to head (be3012d).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...der-controllers/editor-bridge.render-controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3583      +/-   ##
==========================================
- Coverage   31.85%   31.85%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115244   115245       +1     
  Branches    25383    25384       +1     
==========================================
  Hits        36706    36706              
- Misses      78538    78539       +1     
Flag Coverage Δ
31.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 69d513e into dev Sep 25, 2024
9 checks passed
@weird94 weird94 deleted the fix/formula-across-subsheet branch September 25, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants