Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e scrolling & add missing interface for sheet skeleton #3584

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku requested a review from jikkai September 25, 2024 12:10
Copy link

github-actions bot commented Sep 25, 2024

Playwright test results

passed  7 passed
flaky  1 flaky

Details

stats  8 tests across 3 suites
duration  2 minutes, 40 seconds
commit  4abcaa4
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.85%. Comparing base (2fc56ff) to head (6f1c1da).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 2 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3584      +/-   ##
==========================================
- Coverage   31.85%   31.85%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115244   115246       +2     
  Branches    25383    25383              
==========================================
  Hits        36706    36706              
- Misses      78538    78540       +2     
Flag Coverage Δ
31.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 25609a0 into dev Sep 25, 2024
9 checks passed
@jikkai jikkai deleted the fix/e2e-scrolling branch September 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants