Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy sheet should copy filter #3592

Merged
merged 5 commits into from
Sep 27, 2024
Merged

fix: copy sheet should copy filter #3592

merged 5 commits into from
Sep 27, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 26, 2024

close https://github.com/dream-num/univer-pro/issues/940 https://github.com/dream-num/univer-pro/issues/2624 https://github.com/dream-num/univer-pro/issues/2210 https://github.com/dream-num/univer-pro/issues/2232

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 26, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 11 seconds
commit  6873581
info  For more information, see full report

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 31.86%. Comparing base (0ab07d9) to head (6873581).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...filter/src/controllers/sheets-filter.controller.ts 84.37% 5 Missing ⚠️
...lter-ui/src/views/components/SheetsFilterPanel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3592      +/-   ##
==========================================
+ Coverage   31.84%   31.86%   +0.02%     
==========================================
  Files        2194     2194              
  Lines      115259   115343      +84     
  Branches    25383    25407      +24     
==========================================
+ Hits        36706    36759      +53     
- Misses      78553    78584      +31     
Flag Coverage Δ
31.86% <85.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

zhaolixin7 commented Sep 26, 2024

@ybzky 设置筛选后删除再undo,筛选条件未保留

@univer-bot
Copy link

univer-bot bot commented Sep 26, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@ybzky After setting the filter, delete it and then undo, the filter conditions are not retained.

@ybzky ybzky force-pushed the fix-filter-copy-sheet branch from ef130f8 to b69960a Compare September 26, 2024 12:20
@ybzky ybzky requested a review from VicKun4937 as a code owner September 26, 2024 12:20
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oumomomo
Copy link

https://github.com/dream-num/univer-pro/issues/2232
设置筛选条件后删除所有的内容,点击取消筛选无反应
2024_9_27 11_08_05 video.webm

@univer-bot
Copy link

univer-bot bot commented Sep 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/2232
After setting the filter conditions, delete all content and click Cancel Filter. No response.
2024_9_27 11_08_05 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 27, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 27, 2024
@univer-bot univer-bot bot removed the qa:rejected label Sep 27, 2024
@ybzky ybzky merged commit e3620ce into dev Sep 27, 2024
9 checks passed
@ybzky ybzky deleted the fix-filter-copy-sheet branch September 27, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants