Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cell margin bottom should over 1 #3595

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: cell margin bottom should over 1 #3595

merged 1 commit into from
Sep 26, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Sep 26, 2024

close https://github.com/dream-num/univer-pro/issues/2330

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku requested review from ybzky and removed request for yuhongz September 26, 2024 09:08
Copy link

github-actions bot commented Sep 26, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 11 seconds
commit  9ef96e2
info  For more information, see full report

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (b94743c) to head (776023a).

Files with missing lines Patch % Lines
packages/engine-render/src/viewport.ts 0.00% 13 Missing ⚠️
packages/engine-render/src/canvas.ts 0.00% 2 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 1 Missing ⚠️
...lers/render-controllers/sheet.render-controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3595      +/-   ##
==========================================
- Coverage   31.84%   31.84%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115304   115307       +3     
  Branches    25398    25399       +1     
==========================================
  Hits        36719    36719              
- Misses      78585    78588       +3     
Flag Coverage Δ
31.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 26, 2024
@lumixraku lumixraku force-pushed the fix/margin-bottom branch 2 times, most recently from 776023a to 9ef96e2 Compare September 26, 2024 12:48
@lumixraku lumixraku merged commit 65ee6b2 into dev Sep 26, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/margin-bottom branch September 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants