Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-hyper-link-ui): link & doc markSelection error on merged cell #3615

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 28, 2024

close https://github.com/dream-num/univer-pro/issues/2641

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 28, 2024
Copy link

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 10 seconds
commit  66ca49f
info  For more information, see full report

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 31.86%. Comparing base (1113984) to head (66ca49f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
.../sheets-ui/src/services/utils/doc-skeleton-util.ts 0.00% 42 Missing ⚠️
...ets-hyper-link-ui/src/views/CellLinkEdit/index.tsx 0.00% 3 Missing ⚠️
...trollers/sheets-thread-comment-popup.controller.ts 0.00% 2 Missing ⚠️
...nt/src/views/sheets-thread-comment-panel/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3615      +/-   ##
==========================================
- Coverage   31.87%   31.86%   -0.01%     
==========================================
  Files        2193     2193              
  Lines      115294   115311      +17     
  Branches    25402    25407       +5     
==========================================
  Hits        36745    36745              
- Misses      78549    78566      +17     
Flag Coverage Δ
31.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

选中合并单元格添加超链接-单元格,确定时会选中单个单元格
image
2024_9_28 14_28_44 video.webm

google表现:选中整个单元格
image

@univer-bot
Copy link

univer-bot bot commented Sep 28, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Select the merged cell to add a hyperlink-cell, and a single cell will be selected when confirmed
image
2024_9_28 14_28_44 video.webm

Google performance: select the entire cell
image

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Sep 28, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 28, 2024
@univer-bot univer-bot bot removed the qa:rejected label Sep 28, 2024
@weird94 weird94 merged commit 21853cc into dev Sep 28, 2024
10 checks passed
@weird94 weird94 deleted the fix/comment-hover branch September 28, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants