Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): data validation validator status render error #3752

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 14, 2024

close https://github.com/dream-num/univer-pro/issues/2857

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from wzhudev as a code owner October 14, 2024 16:19
@weird94 weird94 changed the title Fix/data validation 1014 fix(sheets-data-validation): data validation validator status render error Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Playwright test results

failed  1 failed
passed  16 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 47 seconds
commit  744ed53
info  For more information, see full report

Failed tests

chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.

Project coverage is 30.97%. Comparing base (e16ead3) to head (744ed53).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ta-validation/src/services/dv-validator-service.ts 0.00% 33 Missing ⚠️
...lidation/src/models/sheet-data-validation-model.ts 0.00% 19 Missing ⚠️
...s-data-validation/src/services/dv-cache.service.ts 0.00% 19 Missing ⚠️
...ation-ui/src/controllers/dv-rerender.controller.ts 0.00% 18 Missing ⚠️
packages/core/src/shared/rxjs.ts 0.00% 7 Missing ⚠️
...idation-ui/src/controllers/dv-render.controller.ts 0.00% 5 Missing ⚠️
...ges/sheets-data-validation-ui/src/mobile-plugin.ts 0.00% 2 Missing ⚠️
packages/sheets-data-validation-ui/src/plugin.ts 0.00% 2 Missing ⚠️
packages/sheets-data-validation/src/plugin.ts 0.00% 2 Missing ⚠️
...lidation/src/services/dv-custom-formula.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3752      +/-   ##
==========================================
- Coverage   31.00%   30.97%   -0.03%     
==========================================
  Files        2280     2281       +1     
  Lines      118356   118451      +95     
  Branches    26088    26110      +22     
==========================================
  Hits        36693    36693              
- Misses      81663    81758      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Oct 15, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Oct 15, 2024
@weird94
Copy link
Contributor Author

weird94 commented Oct 15, 2024

/update-snapshots

@weird94 weird94 merged commit 555e9d5 into dev Oct 15, 2024
8 of 9 checks passed
@weird94 weird94 deleted the fix/data-validation-1014 branch October 15, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants