Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): doc list render error after operation like break-line #3766

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 15, 2024

close https://github.com/dream-num/univer-pro/issues/2856
close https://github.com/dream-num/univer-pro/issues/2855
close https://github.com/dream-num/univer-pro/issues/2851
close https://github.com/dream-num/univer-pro/issues/2721

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 15, 2024

Playwright test results

failed  1 failed
passed  16 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 28 seconds
commit  fa2ab3e
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 2.92683% with 199 lines in your changes missing coverage. Please review.

Project coverage is 30.95%. Comparing base (a4a7cda) to head (fa2ab3e).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/docs/data-model/text-x/build-utils/paragraph.ts 4.30% 89 Missing ⚠️
...s/src/commands/commands/toggle-checkbox.command.ts 0.00% 29 Missing ⚠️
...s/sheets-ui/src/controllers/checkbox.controller.ts 0.00% 27 Missing ⚠️
...ages/docs-ui/src/commands/commands/list.command.ts 0.00% 23 Missing ⚠️
...c/components/docs/extensions/font-and-base-line.ts 0.00% 11 Missing ⚠️
...ocs-ui/src/commands/commands/break-line.command.ts 0.00% 10 Missing ⚠️
...docs/data-model/text-x/build-utils/text-x-utils.ts 0.00% 8 Missing ⚠️
...docs/data-model/text-x/apply-utils/update-apply.ts 0.00% 1 Missing ⚠️
...es/sheets-ui/src/services/hover-manager.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3766      +/-   ##
==========================================
- Coverage   30.97%   30.95%   -0.02%     
==========================================
  Files        2281     2284       +3     
  Lines      118484   118575      +91     
  Branches    26122    26131       +9     
==========================================
+ Hits        36703    36708       +5     
- Misses      81781    81867      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 marked this pull request as draft October 15, 2024 17:36
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Oct 16, 2024
@weird94 weird94 marked this pull request as ready for review October 16, 2024 08:22
@weird94 weird94 requested a review from VicKun4937 as a code owner October 16, 2024 08:22
@weird94 weird94 changed the title fix(docs-ui): doc list fix(docs-ui): doc list render error after operation like break-line Oct 16, 2024
@weird94
Copy link
Contributor Author

weird94 commented Oct 16, 2024

/update-snapshots

@weird94 weird94 merged commit 8c95a53 into dev Oct 16, 2024
8 of 9 checks passed
@weird94 weird94 deleted the feat/sheet-checkbox branch October 16, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants