-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheets-ui): should disable sheet menus on cell editing #3809
Conversation
Origin Title: fix(sheets-ui): should disable sheet menus on cell editing Title: fix(sheets-ui): should disable sheet menus on cell editing Implementation plan
close https://github.com/dream-num/univer-pro/issues/2918 close https://github.com/dream-num/univer-pro/issues/2917 These issues are not reproducible. Pull Request Checklist
|
View Deployment
|
Playwright test resultsDetails 17 tests across 8 suites |
@weird94 1、编辑态时链接入口预期不禁掉 #2917 禅模式下是列表内容如截图,添加链接失败2024_10_21 19_11_17 video.webm #2926 禅模式下选中内容添加链接后,选择完选区回到禅模式时1、显示内容会延迟一会 2、显示如截图时退出禅模式,弹出未消失 |
@weird94 1. The link entry is expected to be lost when editing the state! image #2917 In Zen mode, the list content is as shown in the screenshot, and the link fails to be added 2024_10_21 19_11_17 video.webm #2926 After adding a link to the selected content in Zen mode, when returning to Zen mode after selecting the area 1. The displayed content will be delayed for a while 2. Exit Zen mode when the display is as shown in the screenshot, and the pop-up does not disappear |
实现方案
close https://github.com/dream-num/univer-pro/issues/2918
close https://github.com/dream-num/univer-pro/issues/2500
close https://github.com/dream-num/univer-pro/issues/2870
close https://github.com/dream-num/univer-pro/issues/2919
close https://github.com/dream-num/univer-pro/issues/2899
close https://github.com/dream-num/univer-pro/issues/2904
close https://github.com/dream-num/univer-pro/issues/2639
close https://github.com/dream-num/univer-pro/issues/2917
close https://github.com/dream-num/univer-pro/issues/2926
close https://github.com/dream-num/univer-pro/issues/2924
These issues are not reproducible.
close https://github.com/dream-num/univer-pro/issues/2923
close https://github.com/dream-num/univer-pro/issues/2887
close https://github.com/dream-num/univer-pro/issues/2890
close https://github.com/dream-num/univer-pro/issues/2886
close https://github.com/dream-num/univer-pro/issues/2864
close https://github.com/dream-num/univer-pro/issues/2821
Pull Request Checklist