Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permission): change permission point logic #3826

Merged
merged 19 commits into from
Oct 24, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Oct 22, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 22, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 36 seconds
commit  ab9280e
info  For more information, see full report

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 9.23077% with 177 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (bbc4794) to head (ab9280e).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...ts-ui/src/controllers/menu/permission-menu-util.ts 0.00% 51 Missing ⚠️
...rmission/sheet-permission-view-model.controller.ts 0.00% 42 Missing ⚠️
...ackages/sheets/src/model/range-protection.cache.ts 0.00% 18 Missing ⚠️
...heets-ui/src/views/permission/panel-list/index.tsx 0.00% 13 Missing ⚠️
...rksheet-permission/worksheet-permission.service.ts 0.00% 11 Missing ⚠️
...ission/permission-point/range/delete-protection.ts 0.00% 9 Missing ⚠️
...sion/permission-point/range/manage-collaborator.ts 0.00% 9 Missing ⚠️
...ckages/sheets-ui/src/controllers/menu/menu-util.ts 0.00% 5 Missing ⚠️
...workbook-permission/workbook-permission.service.ts 42.85% 4 Missing ⚠️
...ets-ui/src/views/permission/panel-detail/index.tsx 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3826   +/-   ##
=======================================
  Coverage   31.97%   31.97%           
=======================================
  Files        2343     2348    +5     
  Lines      121010   121094   +84     
  Branches    26780    26785    +5     
=======================================
+ Hits        38689    38719   +30     
- Misses      82321    82375   +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,36 @@
/**
* Copyright 2023-present DreamNum Inc.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要在外边暴露么?

@ybzky ybzky merged commit 7e49171 into dev Oct 24, 2024
9 checks passed
@ybzky ybzky deleted the chore/permission-operate branch October 24, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants