Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): supplement sheet and sheets formula #3859

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Oct 25, 2024

  • SHEET
  • SHEETS

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 changed the title feat/formula: supplement SHEET SHEETS formula feat/formula: supplement sheet and sheets formula Oct 25, 2024
@wpxp123456 wpxp123456 changed the title feat/formula: supplement sheet and sheets formula feat(formula): supplement sheet and sheets formula Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  d8b2820
info  For more information, see full report

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.98%. Comparing base (ff9cf49) to head (d8b2820).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3859      +/-   ##
==========================================
+ Coverage   31.95%   31.98%   +0.02%     
==========================================
  Files        2351     2353       +2     
  Lines      121311   121359      +48     
  Branches    26857    26865       +8     
==========================================
+ Hits        38764    38812      +48     
  Misses      82547    82547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dream-num dream-num deleted a comment from univer-bot bot Oct 25, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 25, 2024
@@ -98,6 +98,11 @@ export interface IFormulaCurrentConfigService {
getClearDependencyTreeCache(): IDirtyUnitSheetNameMap;

getLocale(): LocaleType;

getSheetsInfo(): {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can define an interface for

{
sheetOrder: string[];
sheetNameMap: { [sheetId: string]: string };
}

@wpxp123456 wpxp123456 merged commit 5fcd97a into dev Oct 25, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the feat/supplement-info-formula branch October 25, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants