Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawing): fix inner dom position #3864

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix(drawing): fix inner dom position #3864

merged 4 commits into from
Oct 28, 2024

Conversation

VicKun4937
Copy link
Contributor

  • fix float dom inner size, it should smaller than wrapper

Copy link

github-actions bot commented Oct 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 26, 2024

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 59 seconds
commit  d95b71a
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 31.96%. Comparing base (3126112) to head (d95b71a).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 21 Missing ⚠️
packages/engine-render/src/shape/shape.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3864      +/-   ##
==========================================
- Coverage   31.97%   31.96%   -0.01%     
==========================================
  Files        2353     2353              
  Lines      121378   121410      +32     
  Branches    26857    26864       +7     
==========================================
  Hits        38805    38805              
- Misses      82573    82605      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937 VicKun4937 merged commit c37f24c into dev Oct 28, 2024
8 of 9 checks passed
@VicKun4937 VicKun4937 deleted the fix-drawing-position branch October 28, 2024 11:01
Gggpound pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants