Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawing): fix remove drawing elements the control when not remove… #3873

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix(drawing): fix remove drawing elements the control when not remove… #3873

merged 4 commits into from
Oct 28, 2024

Conversation

VicKun4937
Copy link
Contributor

  • as title , add lisener to remove the control

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  4a02859
info  For more information, see full report

wzhudev
wzhudev approved these changes Oct 28, 2024
View reviewed changes
packages/engine-render/src/scene.transformer.ts Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 31.95%. Comparing base (c37f24c) to head (4a02859).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 12 Missing ⚠️
packages/engine-render/src/scene.transformer.ts 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #3873      +/-   ##
==========================================
- Coverage   31.96%   31.95%   -0.01%     
==========================================
  Files        2353     2353              
  Lines      121410   121426      +16     
  Branches    26864    26866       +2     
==========================================
  Hits        38805    38805              
- Misses      82605    82621      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937 VicKun4937 merged commit 448d32c into dev Oct 28, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-drawing-remove-control branch October 28, 2024 13:48
Gggpound pushed a commit that referenced this pull request Oct 30, 2024
@VicKun4937 @actions-user @Gggpound
fix(drawing): fix remove drawing elements the control when not remove… (
25dd7d3 
#3873)

Co-authored-by: GitHub Actions <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VicKun4937 @wzhudev @actions-user