-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter date group #3881
feat: filter date group #3881
Conversation
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites |
@@ -67,6 +67,20 @@ const locale: typeof zhCN = { | |||
msg: { | |||
'filter-header-forbidden': 'You can\'t move the header row of a filter.', | |||
}, | |||
date: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future we need to support countries that do not use Gregorian calendar.
@@ -137,3 +133,164 @@ export function getFilterByValueItems( | |||
|
|||
return items; | |||
} | |||
|
|||
export function getFilterTreeByValueItems( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have test covered. For example, different number formats of cells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
different types of formats are added to the filter test demo data
b4f5e19
to
7507454
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3881 +/- ##
==========================================
+ Coverage 32.34% 32.41% +0.06%
==========================================
Files 2457 2459 +2
Lines 125883 125971 +88
Branches 28107 28150 +43
==========================================
+ Hits 40717 40831 +114
+ Misses 85166 85140 -26 ☔ View full report in Codecov by Sentry. |
close #xxx
Pull Request Checklist