Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter date group #3881

Merged
merged 12 commits into from
Nov 5, 2024
Merged

feat: filter date group #3881

merged 12 commits into from
Nov 5, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Oct 29, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from wzhudev and removed request for jikkai, yuhongz and Gggpound October 29, 2024 09:53
Copy link

github-actions bot commented Oct 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 29, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  3537995
info  For more information, see full report

packages/design/src/components/tree/Tree.tsx Outdated Show resolved Hide resolved
@@ -67,6 +67,20 @@ const locale: typeof zhCN = {
msg: {
'filter-header-forbidden': 'You can\'t move the header row of a filter.',
},
date: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we need to support countries that do not use Gregorian calendar.

@@ -137,3 +133,164 @@ export function getFilterByValueItems(

return items;
}

export function getFilterTreeByValueItems(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have test covered. For example, different number formats of cells.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different types of formats are added to the filter test demo data

@ybzky ybzky marked this pull request as draft November 2, 2024 06:58
@ybzky ybzky marked this pull request as ready for review November 2, 2024 09:41
@ybzky ybzky requested a review from wzhudev November 2, 2024 09:47
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 77.08333% with 55 lines in your changes missing coverage. Please review.

Project coverage is 32.41%. Comparing base (1dfbd10) to head (3537995).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
...src/views/components/SheetsFilterByValuesPanel.tsx 0.00% 24 Missing ⚠️
...er-ui/src/worker/generate-filter-values.service.ts 85.55% 13 Missing ⚠️
packages/design/src/components/tree/Tree.tsx 78.57% 6 Missing ⚠️
packages/sheets-filter-ui/src/services/util.ts 85.36% 6 Missing ⚠️
...ter-ui/src/services/sheets-filter-panel.service.ts 87.17% 5 Missing ⚠️
packages/sheets-numfmt/src/numfmt-plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3881      +/-   ##
==========================================
+ Coverage   32.34%   32.41%   +0.06%     
==========================================
  Files        2457     2459       +2     
  Lines      125883   125971      +88     
  Branches    28107    28150      +43     
==========================================
+ Hits        40717    40831     +114     
+ Misses      85166    85140      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky merged commit 35f4567 into dev Nov 5, 2024
10 checks passed
@ybzky ybzky deleted the feat-filter-date branch November 5, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants