Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter rollback in another worksheet #3896

Merged
merged 3 commits into from
Nov 4, 2024
Merged

fix: filter rollback in another worksheet #3896

merged 3 commits into from
Nov 4, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Oct 30, 2024

close https://github.com/dream-num/univer-pro/issues/2310
close https://github.com/dream-num/univer-pro/issues/2791

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 30, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  986aa95
info  For more information, see full report

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.34%. Comparing base (1dfbd10) to head (986aa95).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...lers/render-controllers/sheet.render-controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3896   +/-   ##
=======================================
  Coverage   32.34%   32.34%           
=======================================
  Files        2457     2457           
  Lines      125883   125879    -4     
  Branches    28107    28105    -2     
=======================================
  Hits        40717    40717           
+ Misses      85166    85162    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/filter-rollback branch from 1d207aa to 986aa95 Compare November 2, 2024 08:09
@lumixraku lumixraku marked this pull request as ready for review November 2, 2024 08:35
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 2, 2024
@lumixraku lumixraku self-assigned this Nov 2, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 4, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 4, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit e16aa90 into dev Nov 4, 2024
10 checks passed
@wzhudev wzhudev deleted the fix/filter-rollback branch November 4, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants