Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): supplement IMCOTH/IMLOG/IMTANH formula #3909

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Oct 31, 2024

follow google sheet

  • IMCOTH
  • IMLOG
  • IMTANH

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 31, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  a3961f6
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.49%. Comparing base (7c3807f) to head (a3961f6).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3909      +/-   ##
==========================================
+ Coverage   33.44%   33.49%   +0.04%     
==========================================
  Files        2446     2449       +3     
  Lines      126901   126988      +87     
  Branches    28378    28403      +25     
==========================================
+ Hits        42442    42529      +87     
  Misses      84459    84459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oumomomo
Copy link

oumomomo commented Nov 9, 2024

IMCOTH函数

单元格内输入=IMCOTH(COMPLEX(0,0)),错误码不一致
image

@univer-bot
Copy link

univer-bot bot commented Nov 9, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

IMCOTH function

Enter =IMCOTH(COMPLEX(0,0)) in the cell, the error code is inconsistent
image

@wpxp123456 wpxp123456 force-pushed the feat/supplement-im-formula branch from a50e562 to 80aed6f Compare November 21, 2024 03:11
@wpxp123456 wpxp123456 force-pushed the feat/supplement-im-formula branch from 80aed6f to a3961f6 Compare November 21, 2024 06:12
@wpxp123456 wpxp123456 removed the qa:untested This PR is ready to be tested label Nov 21, 2024
@wpxp123456 wpxp123456 merged commit 77e7c67 into dev Nov 21, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the feat/supplement-im-formula branch November 21, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants