Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawing): add optional param to contrl popup #3935

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

VicKun4937
Copy link
Contributor

  • add disablePopup to control popup

Copy link

github-actions bot commented Nov 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 2, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  a1f58aa
info  For more information, see full report

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.36%. Comparing base (b18aba7) to head (a1f58aa).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 6 Missing ⚠️
...i/src/controllers/drawing-popup-menu.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3935   +/-   ##
=======================================
  Coverage   32.35%   32.36%           
=======================================
  Files        2458     2458           
  Lines      125840   125812   -28     
  Branches    28109    28100    -9     
=======================================
+ Hits        40718    40720    +2     
+ Misses      85122    85092   -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937 VicKun4937 merged commit 95bee3e into dev Nov 4, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-chart-pop branch November 4, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants