Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula-bar): an additional selection is inserted when you click … #3964

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Nov 5, 2024

…the Formula Bar

close #https://github.com/dream-num/univer-pro/issues/3114

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Gggpound Gggpound requested a review from Jocs as a code owner November 5, 2024 11:37
Copy link

github-actions bot commented Nov 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound
Copy link
Contributor Author

Gggpound commented Nov 5, 2024

image 这个addRange的链路是非预期的.

@univer-bot
Copy link

univer-bot bot commented Nov 5, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image This link to addRange is unexpected.

Copy link

github-actions bot commented Nov 5, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  26343f6
info  For more information, see full report

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.71%. Comparing base (2bea457) to head (26343f6).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3964      +/-   ##
==========================================
+ Coverage   32.46%   32.71%   +0.24%     
==========================================
  Files        2427     2438      +11     
  Lines      126040   126501     +461     
  Branches    28193    28333     +140     
==========================================
+ Hits        40915    41380     +465     
+ Misses      85125    85121       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 5, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 5, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 5, 2024
@Gggpound Gggpound merged commit 8cda704 into dev Nov 5, 2024
10 checks passed
@Gggpound Gggpound deleted the fix-formula-bar-1102 branch November 5, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants