Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): calculate after renderer #4024

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 9, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir requested a review from DR-Univer November 9, 2024 09:09
@Dushusir Dushusir marked this pull request as ready for review November 9, 2024 09:09
@Dushusir Dushusir requested a review from wzhudev as a code owner November 9, 2024 09:09
Copy link

github-actions bot commented Nov 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 9, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 7 seconds
commit  9b1387d
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (e194b97) to head (0db0315).

Files with missing lines Patch % Lines
packages/engine-formula/src/plugin.ts 0.00% 3 Missing ⚠️
...ckages/sheets-formula/src/sheets-formula.plugin.ts 0.00% 2 Missing ⚠️
.../sheets-formula-ui/src/sheets-formula-ui.plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4024   +/-   ##
=======================================
  Coverage   32.84%   32.85%           
=======================================
  Files        2501     2501           
  Lines      126585   126571   -14     
  Branches    28345    28345           
=======================================
  Hits        41583    41583           
+ Misses      85002    84988   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/fix-formula-lifecycle branch from b5ac407 to 501c7f0 Compare November 9, 2024 09:56
@Dushusir Dushusir requested a review from wzhudev November 9, 2024 09:56
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir merged commit 0afcc5d into dev Nov 9, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/fix-formula-lifecycle branch November 9, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants