Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix formula update operation #4026

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

wpxp123456
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/2436

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 9, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  9169219
info  For more information, see full report

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (0afcc5d) to head (9169219).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...formula/src/controllers/utils/ref-range-formula.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4026      +/-   ##
==========================================
- Coverage   32.85%   32.85%   -0.01%     
==========================================
  Files        2501     2501              
  Lines      126575   126577       +2     
  Branches    28347    28348       +1     
==========================================
  Hits        41584    41584              
- Misses      84991    84993       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 12, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 12, 2024
@wpxp123456 wpxp123456 merged commit 54599ce into dev Nov 12, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the fix/formula-update branch November 12, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants