Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-drawing-ui): support sheet cell image #4036

Merged
merged 176 commits into from
Nov 30, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 11, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 513 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (59b95fa) to head (3edfaa1).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...-ui/src/controllers/sheet-cell-image.controller.ts 0.00% 93 Missing ⚠️
...src/docs/data-model/text-x/build-utils/drawings.ts 1.35% 73 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 71 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 61 Missing ⚠️
packages/core/src/shared/cache/image-cache.ts 0.00% 27 Missing ⚠️
.../drawing-ui/src/services/drawing-render.service.ts 0.00% 19 Missing ⚠️
...heets-ui/src/controllers/auto-height.controller.ts 0.00% 14 Missing ⚠️
...editor/src/commands/commands/zen-editor.command.ts 0.00% 12 Missing ⚠️
...ges/core/src/services/image-io/image-io.service.ts 0.00% 11 Missing ⚠️
...ontrollers/sheet-cell-image-autofill.controller.ts 0.00% 11 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4036      +/-   ##
==========================================
- Coverage   33.78%   33.68%   -0.11%     
==========================================
  Files        2485     2490       +5     
  Lines      127547   128010     +463     
  Branches    28594    28694     +100     
==========================================
+ Hits        43093    43117      +24     
- Misses      84454    84893     +439     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 28, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 28, 2024
@hexf00 hexf00 added the 0.5.1 label Nov 29, 2024
@weird94 weird94 merged commit 244511d into dev Nov 30, 2024
8 of 9 checks passed
@weird94 weird94 deleted the feat/sheet-cell-image branch November 30, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5.1 qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants