Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): maximum call stack #4088

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(sheet): maximum call stack #4088

merged 1 commit into from
Nov 19, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 16, 2024

close #4065

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir marked this pull request as ready for review November 16, 2024 12:28
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 16, 2024
Copy link

github-actions bot commented Nov 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  5 minutes, 39 seconds
commit  1126836
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.04%. Comparing base (8597d44) to head (1126836).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4088   +/-   ##
=======================================
  Coverage   33.04%   33.04%           
=======================================
  Files        2437     2437           
  Lines      126821   126821           
  Branches    28393    28393           
=======================================
  Hits        41912    41912           
  Misses      84909    84909           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 18, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 18, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit d6d2e3f into dev Nov 19, 2024
9 of 10 checks passed
@wzhudev wzhudev deleted the dushusir/fix-formula1116 branch November 19, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Maximum call stack size exceeded error while applying formula
3 participants