Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection should stop response after a popup shown #4156

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 26, 2024

close https://github.com/dream-num/univer-pro/issues/3392

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku marked this pull request as ready for review November 26, 2024 08:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 49 seconds
commit  2fb4444
info  For more information, see full report

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (fe472fb) to head (2fb4444).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/engine.ts 0.00% 33 Missing ⚠️
packages/engine-render/src/scene.input-manager.ts 0.00% 7 Missing ⚠️
packages/engine-render/src/base-object.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/shape/scroll-bar.ts 0.00% 2 Missing ⚠️
...services/selection/doc-selection-render.service.ts 0.00% 1 Missing ⚠️
...kages/docs-ui/src/services/selection/text-range.ts 0.00% 1 Missing ⚠️
...ender/src/render-manager/render-manager.service.ts 0.00% 1 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 0.00% 1 Missing ⚠️
...src/services/selection/selection-render.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4156      +/-   ##
==========================================
+ Coverage   33.76%   33.78%   +0.01%     
==========================================
  Files        2486     2485       -1     
  Lines      127614   127546      -68     
  Branches    28584    28593       +9     
==========================================
  Hits        43092    43092              
+ Misses      84522    84454      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 27, 2024
@lumixraku lumixraku merged commit a4b38af into dev Nov 30, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/pointer-cancel branch November 30, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants