Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): update formula data model #4159

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 26, 2024

What's updated?

  • remove formula data in formulaDataModel. Large memory case decreased from 2100M to 1903M

How to test?

Test any formula-related use cases

For example

  • Normal SUM calculation
  • Cross-sheet formula
  • Array formula
  • Ref range change

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 26, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 50 seconds
commit  918e35b
info  For more information, see full report

@Dushusir Dushusir force-pushed the dushusir/formula-data-model1125 branch from 4d3b3fa to 6f4e86b Compare November 27, 2024 07:20
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 35 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (81cf367) to head (918e35b).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...es/engine-formula/src/models/formula-data.model.ts 73.23% 19 Missing ⚠️
...rmula/src/controllers/update-formula.controller.ts 0.00% 9 Missing ⚠️
...ta-validation/src/services/dv-validator-service.ts 0.00% 2 Missing ⚠️
...ui/src/controllers/formula-clipboard.controller.ts 33.33% 2 Missing ⚠️
.../src/controllers/formula-editor-show.controller.ts 0.00% 2 Missing ⚠️
...gine-formula/src/models/utils/formula-data-util.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4159      +/-   ##
==========================================
+ Coverage   33.77%   33.78%   +0.01%     
==========================================
  Files        2487     2487              
  Lines      127668   127621      -47     
  Branches    28601    28583      -18     
==========================================
  Hits        43121    43121              
+ Misses      84547    84500      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review November 27, 2024 07:39
@Dushusir Dushusir force-pushed the dushusir/formula-data-model1125 branch from 6f4e86b to 76d18da Compare November 27, 2024 09:02
@Dushusir Dushusir force-pushed the dushusir/formula-data-model1125 branch from 76d18da to deb5200 Compare November 29, 2024 02:36
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 29, 2024
@Dushusir Dushusir force-pushed the dushusir/formula-data-model1125 branch from ce277e3 to 918e35b Compare November 29, 2024 09:11
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dushusir Dushusir merged commit 243acdb into dev Nov 29, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-data-model1125 branch November 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants