Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): the style that involves conditional formatting does not fall #4195

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

Gggpound
Copy link
Contributor

…atting does not fall

close https://github.com/dream-num/univer-pro/issues/2495

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound force-pushed the fix-cf-after-cell-editor-1130 branch 2 times, most recently from bb2306c to c133344 Compare November 30, 2024 09:46
Copy link

github-actions bot commented Nov 30, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  7c9451d
info  For more information, see full report

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (9a085c3) to head (7c9451d).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...matting-ui/src/controllers/cf.editor.controller.ts 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4195      +/-   ##
==========================================
- Coverage   33.68%   33.68%   -0.01%     
==========================================
  Files        2490     2490              
  Lines      128020   128023       +3     
  Branches    28690    28692       +2     
==========================================
- Hits        43128    43126       -2     
- Misses      84892    84897       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai changed the title fix(conditional-formatting): the style that involves conditional form… fix(conditional-formatting): the style that involves conditional formatting does not fall Nov 30, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 30, 2024
@Gggpound Gggpound force-pushed the fix-cf-after-cell-editor-1130 branch from c133344 to 7c9451d Compare November 30, 2024 11:33
@Gggpound Gggpound merged commit d7f5f72 into dev Nov 30, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-cf-after-cell-editor-1130 branch November 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants