Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): support sse in network fetch #2482

Merged
merged 5 commits into from
Jun 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: sse always use progress
  • Loading branch information
wzhudev committed Jun 12, 2024
commit 7a2e85815514f71b81490b12576859df97905f5d
3 changes: 1 addition & 2 deletions packages/network/src/services/http/http.service.ts
Original file line number Diff line number Diff line change
@@ -136,7 +136,7 @@ export class HTTPService extends Disposable {
headers,
params,
withCredentials: options?.withCredentials ?? false,
reportProgress: options?.reportProgress ?? false,
reportProgress: true,
responseType: options?.responseType ?? 'json',
body: (['GET', 'DELETE'].includes(method)) ? undefined : (options as IPostRequestParams)?.body,
});
@@ -161,7 +161,6 @@ export class HTTPService extends Disposable {
withCredentials: options?.withCredentials ?? false, // default value for withCredentials is false by MDN
responseType: options?.responseType ?? 'json',
body: (['GET', 'DELETE'].includes(method)) ? undefined : (options as IPostRequestParams)?.body,

});

// eslint-disable-next-line ts/no-explicit-any
Loading