Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): data validation validator empty ranges & comment active issue & sheet-hyper-link autofill #3003

Merged
merged 5 commits into from
Aug 10, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Aug 9, 2024

close https://github.com/dream-num/univer-pro/issues/1554
close https://github.com/dream-num/univer-pro/issues/1629
close https://github.com/dream-num/univer-pro/issues/1549

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners August 9, 2024 15:29
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 26.10%. Comparing base (94d436c) to head (4fdd4f6).

Files Patch % Lines
...er-link-ui/src/controllers/auto-fill.controller.ts 0.00% 11 Missing ⚠️
.../sheets-data-validation/src/views/detail/index.tsx 0.00% 3 Missing ⚠️
...rc/controllers/sheets-thread-comment.controller.ts 0.00% 2 Missing ⚠️
packages/ui/src/services/editor/editor.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3003      +/-   ##
==========================================
- Coverage   26.11%   26.10%   -0.01%     
==========================================
  Files        1907     1907              
  Lines      101815   101820       +5     
  Branches    21737    21739       +2     
==========================================
  Hits        26585    26585              
- Misses      75230    75235       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 changed the title fix(sheets-data-validation) data validation validator empty ranges & comment active issue fix(sheets-data-validation): data validation validator empty ranges & comment active issue Aug 9, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Aug 9, 2024
@weird94 weird94 changed the title fix(sheets-data-validation): data validation validator empty ranges & comment active issue fix(sheets-data-validation): data validation validator empty ranges & comment active issue & sheet-hyper-link autofill Aug 9, 2024
@weird94 weird94 removed the qa:untested This PR is ready to be tested label Aug 9, 2024
@weird94 weird94 merged commit 3271885 into dev Aug 10, 2024
11 checks passed
@weird94 weird94 deleted the fix/data-validation-daily0810 branch August 10, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants