Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shinymanager logs graphics not showing #26

Closed
bthieurmel opened this issue Mar 11, 2021 · 3 comments
Closed

shinymanager logs graphics not showing #26

bthieurmel opened this issue Mar 11, 2021 · 3 comments

Comments

@bthieurmel
Copy link

bthieurmel commented Mar 11, 2021 •
edited
Loading

Due to billboarder JS error. Only with "0.3.0"

So I think it's a billboarder issue``...!
@pvictor
Copy link
Member

pvictor commented Mar 11, 2021

Oups, I'll fix that

@pvictor
Copy link
Member

pvictor commented Mar 22, 2021

This is caused by the max argument here : https://github.com/datastorm-open/shinymanager/blob/af19454ce8ef8393b05ef73eec2e22a592b41949/R/modules-logs.R#L228

Removing , max = max(nb_log_day$day) + 1 will fix the issue

Otherwise this is fixed in billboard.js here : naver/billboard.js#1981
I wait for the next release and I will upgrade billboarder on CRAN.

@bthieurmel
Copy link
Author

Ok. Thanks. I've just remove max = max(nb_log_day$day) + 1 in shinymanager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pvictor @bthieurmel