Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page find method signature should be corrected #27

Merged
merged 1 commit into from
Feb 6, 2013
Merged

Page find method signature should be corrected #27

merged 1 commit into from
Feb 6, 2013

Conversation

mpemer
Copy link
Collaborator

@mpemer mpemer commented Jan 25, 2013

Made a simple change to a method signature to address a stack trace when trying to generate a gollum site (with gollum version 2.4.11 installed).

The commit aims to resolve #25.

commit 963c2e9
Author: Marcus Pemer <marcus@iteego.com>
Date:   Fri Jan 25 09:51:19 2013 +0100

    Matched signature of find method with that of the parent class from gollum 2.4.11.

    The mismatch in signature caused a stacktrace when trying to generate a site.

:100644 100644 357f9ba... c72584d... M  lib/gollum-site/page.rb

@mpemer
Matched signature of find method with that of the parent class from g…
963c2e9 
…ollum 2.4.11.

The mismatch in signature caused a stacktrace when trying to generate a site.
@mpemer mpemer mentioned this pull request Jan 25, 2013
Open
dreverri added a commit that referenced this pull request Feb 6, 2013
@dreverri
Merge pull request #27 from mpemer/master
4c63a4a 
Page find method signature should be corrected
@dreverri dreverri merged commit 4c63a4a into dreverri:master Feb 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gollum-site generate fails with stacktrace
2 participants
@mpemer @dreverri