Skip to content

Commit

Permalink
fix(input): add 'type="button"' to button tag
Browse files Browse the repository at this point in the history
Add attribute 'type="button"' to button tag. The missing attribute
caused forms with ion-toggle/ion-radio to not be submitted as a normal
form.
  • Loading branch information
adamdbradley committed Apr 11, 2016
1 parent f723894 commit f17f517
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions ionic/components/radio/radio-button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {RadioGroup} from './radio-group';
'<div class="radio-inner"></div>' +
'</div>' +
'<button role="radio" ' +
'type="button" ' +
'[id]="id" ' +
'[attr.aria-checked]="_checked" ' +
'[attr.aria-labelledby]="_labelId" ' +
Expand Down
1 change: 1 addition & 0 deletions ionic/components/toggle/toggle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const TOGGLE_VALUE_ACCESSOR = new Provider(
'<div class="toggle-inner"></div>' +
'</div>' +
'<button role="checkbox" ' +
'type="button" ' +
'[id]="id" ' +
'[attr.aria-checked]="_checked" ' +
'[attr.aria-labelledby]="_labelId" ' +
Expand Down

0 comments on commit f17f517

Please sign in to comment.