Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 - Feature - Toast Component w/o Ionic Native #5582

Closed
danbucholtz opened this issue Feb 24, 2016 · 11 comments
Closed

V2 - Feature - Toast Component w/o Ionic Native #5582

danbucholtz opened this issue Feb 24, 2016 · 11 comments
Assignees
@brandyscarney
Labels
help wanted a good issue for the community
Milestone
2.0.0-beta.6

Comments

@danbucholtz
Copy link
Contributor

Short description of the problem:

I'd like to see a built-in toast component similar to the alerts. It would be great to have this as a core component so we can use it without Cordova.

What behavior are you expecting?

Show a nice looking modal that fades out after a given time-out

Ionic Version: 1.x / 2.x

2.x

Browser & Operating System: iOS / Android / Chrome

All
@luchillo17
Copy link
Contributor

It indeed would be great to be native, but right now you can just install the cordova toast plugin so this most likely will be made far later in the roadmap, if it ever make it to the roadmap.

@danbucholtz
Copy link
Contributor Author

Totally agree @Luchillo. That's what I'm doing now. However - if the mobile web is to be a first-class cititzen, having an OOTB component would be a big win. I also think the effort would not be significant given how similar a toast is to the Loader and/or Alert components. Loader is coming soon.

@brandyscarney brandyscarney added this to the 2.0.0-beta.10 milestone Feb 24, 2016
@brandyscarney
Copy link
Member

Added to the roadmap, thanks!

@brandyscarney brandyscarney added help wanted a good issue for the community feature and removed alert labels Feb 24, 2016
@dmackerman
Copy link

Curious, are there specs for what this should look like? I'd imagine for Android, it'd mimic the Toast spec for Material Design, but iOS has no such spec.

@brandyscarney
Copy link
Member

@dmackerman We are going to follow the Material Design spec for Android, the iOS version will look similar to the Android version and we will just tweak it as necessary. 😄

@dmackerman
Copy link

@brandyscarney sounds good. Is there active work being done on this, or should I take a crack at it?

@brandyscarney
Copy link
Member

@dmackerman We won't be working on this until beta.10 (unless it gets moved up) so if you'd like to work on it that would be great! It should just match the action sheet animation for now and then we can tweak that if we need to. If you'd like to look into it you can ping me for any questions. I'm thinking the directory can just be called "toast" cc @adamdbradley

@dmackerman
Copy link

Awesome. I'll take a look at extending ActionSheet and see how far that gets me. Looping in @carlospaelinck for collaboration purposes. 😄

@dmackerman dmackerman mentioned this issue Mar 22, 2016
Merged
4 tasks
@dmackerman
Copy link

@danbucholtz @Luchillo: feel free to help out and give your feedback on this PR: #5906 😄

@brandyscarney brandyscarney self-assigned this Apr 20, 2016
brandyscarney added a commit that referenced this issue Apr 21, 2016
@brandyscarney
fix(toast): remove default duration, allow close button click when bd…
d6589e1 
… disabled

Set default text for the close button if nothing is passed. Updated
tests and API docs.

references #5582
@brandyscarney brandyscarney mentioned this issue Apr 21, 2016
Closed
brandyscarney added a commit that referenced this issue Apr 21, 2016
@brandyscarney
feat(toast): display the toast even on page change unless dismissOnPa…
0264532 
…geChange is passed

fix animation and darken iOS background a bit.

closes #5582
@brandyscarney
Copy link
Member

A big thanks to @dmackerman for adding this component! This will be released in beta.6. 😄

brandyscarney added a commit that referenced this issue Apr 21, 2016
@brandyscarney
fix(toast): remove unused options
f9ea2d8 
references #5582
@danbucholtz
Copy link
Contributor Author

@dmackerman, fantastic work! We are all very excited that we landed a feature entirely from the community. This is so awesome! Thanks for contributing!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
help wanted a good issue for the community
Projects
None yet
Milestone
2.0.0-beta.6
Development

No branches or pull requests
5 participants
@dmackerman @danbucholtz @brandyscarney @Ionitron @luchillo17