Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inputs #5835

Closed
brandyscarney opened this issue Mar 14, 2016 · 1 comment
Closed

Fix inputs #5835

brandyscarney opened this issue Mar 14, 2016 · 1 comment
Assignees
@brandyscarney
Milestone
2.0.0-beta.4

Comments

@brandyscarney
Copy link
Member

Input buttons have 8px padding right and look weird with buttons wrapped in divs with 16px padding. Should probably handle this in the framework and just have windows take on more padding since it doesn't do borders like the other modes.

screenshot 2016-03-14 14 31 44
@brandyscarney brandyscarney self-assigned this Mar 14, 2016
@brandyscarney
Copy link
Member Author

This is actually an issue where the input is being applied the margin but it is exceeding the ion-input container and it affects all modes. Going to add to beta.4 to work on with #5787

@brandyscarney brandyscarney added this to the 2.0.0-beta.4 milestone Mar 14, 2016
@brandyscarney brandyscarney changed the title Fix windows input Fix inputs Mar 14, 2016
brandyscarney added a commit that referenced this issue Mar 15, 2016
@brandyscarney
fix(input): update width of inputs so they don't exceed the item
4d4f1d4 
fixes #5835
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.4
Development

No branches or pull requests
1 participant
@brandyscarney