[FEATURE]: Don't throw when .values() is called with an empty array

[miketromba]

Describe what you want

I recently converted my codebase over from Prisma to drizzle, and I have had multiple runtime bugs slip into production where I was passing in an empty array to insert.values() and getting this error: values() must be called with at least one value

The problem is, sometimes you need to dynamically create an array before passing it into the insert function,

const oldItems = [/* some retrieved array of items of unknown length */]
const newItems = oldItems.map(old => ({
    ...old,
    id: randomId()
}))

and it is very easy to forget to wrap the code in:

if(newItems.length){
    // perform insert
}

I propose allowing empty arrays to be passed in by simply resolving the promise with an early return instead of throwing an error. To me, this seems like the lesser of two evils.

[emdede]

👍 Would be great to also have this for inArray. It is work-aroundable, like OP said, but generates significant amount of noise in the code, and acts as potential source for runtime errors due to being a "bug" TS is not able to catch.

Fun fact: While I was checking my code for one of the usages to include here as an example, I did notice a bug because of exactly that.

        if (onlyIds.length) {
          await tx.insert(applicationServiceConnections).values(
            onlyIds.map((serviceId) => ({
              serviceId,
              applicationId: id,
            }))
          )
        }

        const serviceRows = await tx.query.services.findMany({
          with: {
            applications: true,
          },
          where: inArray(services.id, onlyIds),
        })

In the first block, I thought about the length check. But for the following query, I forgot it => runtime error.
If it could be made a TS Error, that would work for me, too.

[miketromba]

@emdede Agreed, if it was possible to make it a TS error, that might be the ideal solution.

[Angelelz]

It's hard to provide an API that everybody is happy with. Please see #441 for additional context.
I try to not make any db call without a try-catch because it's an over-the-wire request and errors do occur.
In your case it's a dynamic array so TS can't help either. I don't think returning early is a good option either because the return type will depend on the driver and if the query has a .returning() or not. It's will also be breaking change.
Maybe find a way to use a linter to detect this type of issues?
Please feel free to reopen if you have any other ideas.