Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup boxes don't close when switching tabs via shortcut #31

Open
nerivera opened this issue Feb 13, 2022 · 4 comments
Open

Popup boxes don't close when switching tabs via shortcut #31

nerivera opened this issue Feb 13, 2022 · 4 comments

Comments

@nerivera
Copy link
Contributor

nerivera commented Feb 13, 2022

Summary

The popup boxes that appear when you click on the extension icon persist when switching tabs using the keyboard shortcuts (e.g. ctrl+tab). This also includes closing the tab (ctrl/command+W) and opening a new tab (ctrl/command+T). It does not include closing the current window or opening a new window. This happens in both regular and private windows.

Steps to reproduce

  1. Open two arbitrary websites on two different tabs
  2. Click on the extension icon on either site so that the popup box appears
  3. Use a keyboard shortcut to navigate to a different tab, open a new tab, or close the current tab
  4. Note that the popup box remains open

Expected behavior

The popup box should close when switching tabs or should change to match the rating of the tab being switched to.

Device info

macOS Monterey 12.2.1
Firefox 97.0 (64-bit)
Media Bias/Fact Check Extension 3.3.0

I did not test this on other browsers or operating systems

@drmikecrowe
Copy link
Owner

So, I'm not sure this is something I can/should fix. For me, the same functionality exists in:

  • Firefox Account
  • Lastpass
  • Awesome Screenshot
  • etc

Seems like this is how Firefox operates

@nerivera
Copy link
Contributor Author

nerivera commented Mar 4, 2022

@drmikecrowe For all of those, it makes sense for the popup box to stay open without changing when switching tabs. Firefox Account and LastPass don't care about the current tab, and Awesome Screenshot only cares once you start taking the screenshot or recording. However, the MBFC popup box is specific to the current tab, so I don't think the same logic applies.

@drmikecrowe
Copy link
Owner

My point was more this is Firefox specific operation than something I control. In Chromium based browsers, I don't specifically close it when the tab changes, the browser does that. Let me investigate who difficult it will be

@nerivera
Copy link
Contributor Author

nerivera commented Mar 4, 2022

@drmikecrowe You don't have to close the pop-up box. You should just be able to update what it says when the tab changes, if that's easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants