Retrofit 설정 #13
Merged
Retrofit 설정 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisemuji
requested changes
Jun 28, 2023
Comment on lines
-2
to
+3
| id("droidknights.kotlin.library") | ||
| id("droidknights.kotlin.hilt") | ||
| id("droidknights.android.library") | ||
| id("droidknights.android.hilt") |
There was a problem hiding this comment.
네트워크 외에도 로컬 관련 로직이 포함될 것 같아서 kotlin --> android 모듈로 변경되었습니다.
| @Provides | ||
| @Singleton | ||
| fun provideRetrofit(okHttpClient: OkHttpClient): Retrofit = Retrofit.Builder() | ||
| .baseUrl(BASE_URL) |
There was a problem hiding this comment.
Kotlinx serialization은 의존성만 추가하셨는데 ConverterFactory 등록도 같이 해주시면 어떨까요?
|
@wisemuji |
|
알림을 놓쳤네요 🥲 확인했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)