Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

후원사 사진 에셋 추가 #183

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

malibinYun
Copy link
Member

Issue

Overview (Required)

image

이전 2020 APP 경로를 참고해서 배치했습니다.
data layer 등에 따로 패키지를 분리해서, drawable과는 무관하게 배치시키는 게 나을까요?
원격 링크를 얻어내려는 작업이라 어떤 방법이든 목적을 달성합니다.

@malibinYun malibinYun self-assigned this Aug 15, 2023
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 각 기능 모듈에서 재사용 할 수 있는 리소스는 core-ui 모듈에 위치시키고 있습니다.
참고: #140

단, 해당 후원사 사진 에셋은 home 모듈에서만 사용될 예정이라 :feature:home 하위에 위치하는 것이 적절해보입니다!

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦈

@malibinYun malibinYun merged commit f61eab2 into droidknights:main Aug 15, 2023
1 check passed
@malibinYun malibinYun deleted the feature/#146 branch August 15, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

후원사 사진 에셋 추가
3 participants