Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FEAT)[#292] data 모듈에서 interface 정의 부분을 별도 모듈로 분리 #293

Merged
merged 1 commit into from
May 22, 2024

Conversation

taehwandev
Copy link
Member

Issue

Overview (Required)

  • interface 부분만 별도 모듈로 분리
  • 정의 부분을 제외한 interface 만을 바라보도록 분리하여 관리함으로써 효율적인 작업 가능

@taehwandev taehwandev self-assigned this May 21, 2024
@taehwandev
Copy link
Member Author

detekt는 뒤에서 수정

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 파일 경로만 확인해주세요!

related to: #252

@@ -1,4 +1,4 @@
package com.droidknights.app.core.data.repository
package com.droidknights.app.core.data.repository.api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정된 경로에 맞게 테스트 경로도 변경해주세요 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영되어있습니다.!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

착각했네유 😅 머쓱

@taehwandev taehwandev merged commit c8c5c7f into main May 22, 2024
1 check failed
@taehwandev taehwandev deleted the 2024/feature/split-api branch June 10, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants