[Feature/PreviewParameterProvider] Preview Parameter Provider 추가 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results19 tests 19 ✅ 5s ⏱️ Results for commit 7cdd4f3. ♻️ This comment has been updated with latest results. |
taehwandev
reviewed
Jun 5, 2024
| @@ -77,14 +79,25 @@ internal fun BookmarkCard( | |||
| } | |||
| } | |||
|
|
|||
| class RoomPreviewParameterProvider : PreviewParameterProvider<Room> { | |||
There was a problem hiding this comment.
모듈 내부에 만 있다보니 internal 키워두 있는것이 좋을것 같네요.
There was a problem hiding this comment.
넵! 모듈 내부에서 사용하는 모든 PreviewParameterProvider에 internal 키워드 추가했습니다 :)
taehwandev
reviewed
Jun 5, 2024
| BookMarkItemForPreview(isEditMode = true) | ||
| BookMarkItemForPreview(isEditMode = true) | ||
| BookMarkItemForPreview(isEditMode = isEditMode) | ||
| BookMarkItemForPreview(isEditMode = isEditMode) |
There was a problem hiding this comment.
이 부분까지 PreviewParameterProvider 까지는 불필요해보이네요.
그리고 하나면 이미 2개가 뜰것 같군요.
There was a problem hiding this comment.
넵 알겠습니다!
이전 코드로 롤백시키기 보다는 하나의 Preview내부에서 true하나, false 하나 하여 모든 case를 볼 수 있도록 수정하였습니다. 리뷰 감사합니다 :)
There was a problem hiding this comment.
추가로 BookmarkedPreviewParameterProvider 또한 단순한 true/false이기 때문에 같은 방식으로 수정하였습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Screenshot