Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[designsystem] 폰트 스타일 재정의 #96

Merged
merged 8 commits into from
Jul 26, 2023
Merged

[designsystem] 폰트 스타일 재정의 #96

merged 8 commits into from
Jul 26, 2023

Conversation

wisemuji
Copy link
Member

@wisemuji wisemuji commented Jul 25, 2023 •
edited
Loading

Issue

Overview (Required)

  • MaterialTheme Typography가 아닌 Local Custom Typography를 참조하도록 변경
  • Material 스타일을 따라가려고 했으나, 각 폰트 스타일 별 weight과 letter spacing이 상이하여 별도의 custom font 정의

Links

@wisemuji wisemuji added the enhancement New feature or request label Jul 25, 2023
@wisemuji wisemuji requested a review from laco-dev July 25, 2023 08:45
@wisemuji wisemuji self-assigned this Jul 25, 2023
@wisemuji wisemuji requested a review from laco-dev July 26, 2023 13:53
laco-dev
laco-dev approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@laco-dev laco-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다. 🙏🏻

@wisemuji
Copy link
Member Author

컨플릭트만 해결했습니다

@wisemuji wisemuji merged commit 66cfb60 into droidknights:main Jul 26, 2023
@wisemuji wisemuji deleted the feature/#73 branch July 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laco-dev laco-dev laco-dev approved these changes

Assignees

@wisemuji wisemuji

Labels
2023 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[designsystem] 폰트 스타일 재정의
3 participants
@wisemuji @laco-dev @taehwandev