-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support hostname target #1455
Conversation
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
👍👍 hi, please help us fix the unit test error.
|
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
updated the test case, improved the regex. |
@ldysdu Happy New Year! |
hi, it seem something wrong in [INFO] ------------------------------------------------------------- |
hi, it seem something wrong in [INFO] ------------------------------------------------------------- |
Signed-off-by: ldysdu <ldysdu@163.com>
sorry for my poor java skill, and the poor network connection. 😂 |
@ldysdu No need to apologize, it’s a great job to take the first step contribute 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@all-contributors please add @ldysdu for code |
I've put up a pull request to add @ldysdu! 🎉 |
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
Signed-off-by: ldysdu <ldysdu@163.com>
support hostname target
close #1452