Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unwanted parsing and stringification count at editing task #12

Closed
1 task done
dromse opened this issue Apr 12, 2024 · 2 comments
Closed
1 task done

[Bug]: Unwanted parsing and stringification count at editing task #12

dromse opened this issue Apr 12, 2024 · 2 comments
Assignees
Labels
Android Bug Something isn't working Linux

Comments

@dromse
Copy link
Owner

dromse commented Apr 12, 2024

What happened?

When grind manger is open and I want to write count to my task in open note, it starts to parse and broke task a little.

Steps to reproduce

  • Open grind manger with Tasks
  • Start edit task in open note
  • Try add #count and this bug appear

Plugin Version

1.0.6

Obsidian Version

1.5.12

What platform are you seeing the problem on? (Can be multiple)

Linux, Android

Relevant log output

No response

Additional questions

  • I want to work on this issue
@dromse dromse added Bug Something isn't working Android Linux labels Apr 12, 2024
@dromse dromse self-assigned this Apr 12, 2024
@dromse
Copy link
Owner Author

dromse commented Apr 12, 2024

It requires to research why task stringification happens at all. But it's not big bug, just annoying sometimes.

@dromse dromse moved this to Backlog in Gamified Tasks Kanban Apr 12, 2024
@dromse dromse changed the title [Bug]: Unwanted parsing ans stringyfing count at editing task [Bug]: Unwanted parsing and stringification count at editing task Apr 13, 2024
@dromse dromse moved this from Backlog to Doing in Gamified Tasks Kanban Apr 19, 2024
@dromse
Copy link
Owner Author

dromse commented Apr 19, 2024

I discover that bug appear in recurring mode:
https://github.com/dromse/obsidian-grind-manager/blob/35388b11f5e098f59f8556febecd1cb342ac1620/src/hooks/useTasks/index.ts#L113-L128

Problem:updateTask executes permanently regardless of needs to reset recurring task.
Because of it, when we add #every tag and start to edit task in our note it triggers vault modification, which triggers filter update, which triggers resetting recurring task, which trigger updateTask constantly 😅.
Therefore it starts to parse middlewares and stratifying it back by order: https://github.com/dromse/obsidian-grind-manager/blob/35388b11f5e098f59f8556febecd1cb342ac1620/src/hooks/useTasks/consts.ts#L91-L99

Steps to solve a problem: Move updateTask inside if statement to trigger only on reset tasks.

@dromse dromse added this to the 1.2.0 milestone Apr 19, 2024
@dromse dromse closed this as completed in ba5feff Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Doing to Done in Gamified Tasks Kanban Apr 19, 2024
@dromse dromse removed this from the 1.2.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Bug Something isn't working Linux
Projects
Status: Done
Development

No branches or pull requests

1 participant