Update Docker dind to 20.10.7-dind #327

prologic · 2021-07-13T09:15:53Z

Fixes #326

I believe this resolves the issue I described in #326

I'm not sure how to test this myself, without just building my own plugins/docker
which I haven't done bfore...

bradrydzewski · 2021-07-13T13:21:16Z

There is a problem with the official Docker-in-Docker images that prevents upgrading at the moment. See #306 (comment)

CirnoT · 2021-07-13T17:20:43Z

Either Docker version must be upgraded or #322 must be merged again (can't see why it would cause mentioned issues, possibly these were stray issues unrelated to changes made or possibly users are using cgroupsv2) or we will block using Alpine 3.14 images forever.

In addition, the old version of Docker prevents usage of cgroupsv2.

techknowlogick · 2021-07-13T19:35:35Z

@CirnoT I've built and pushed my fork here with the linked PR: https://hub.docker.com/r/techknowlogick/drone-docker for arm64&amd64 in case you need it.

prologic · 2021-07-13T23:34:03Z

There is a problem with the official Docker-in-Docker images that prevents upgrading at the moment. See #306 (comment)

Is it worth holding back for one platform? THis is CI we're talking about here, I'd imagine most CI runs are on amd64 and presumably on Linux anyway. Without the update a lot of folks's workflows that depend on Make and use Alpine are broken.

prologic · 2021-07-14T01:17:16Z

So I worked out how to build and use this in my environment, but there are problems with it. See attached log.

logs_yarnsocial_yarn_1_3.log

CirnoT · 2021-07-14T01:29:48Z

Is it worth holding back for one platform? THis is CI we're talking about here, I'd imagine most CI runs are on amd64 and presumably on Linux anyway.

ARM (more specifically however ARM64) is gaining more traction every day, abandoning it here would bring more bad than the Alpine 3.14 issue.
While Drone definitely needs to support ARM32 v6/v7, is it worth keeping DID support for this architecture still @bradrydzewski? I imagine nowadays most CI/CD aimed at this architecture would be native code for embedded applications. I suppose Docker here is of similar opinion as they clearly don't consider this platform of importance enough to fix the issue for months. Frankly I suspect they'd drop it entirely rather than fixing it.

prologic · 2021-07-14T01:39:08Z

Regardless of the support of other arches (I agree they should continue to be supproted), I can't even get the Docker daemon started when upgrading the plugin to use 20.10.7-dind. There are numerous problems with the startup, mostly around "Operation not permitted" and IPTables rubbish. I'm actually not sure how to resolve any of these at the moment...

prologic · 2021-07-14T02:08:51Z

Ahhh I found what I needed

DRONE_RUNNER_PRIVILEGED_IMAGES

techknowlogick · 2021-07-14T02:31:56Z

@prologic a note, if you use the autoscaler the env var you'll need to set for the autoscaler itself is DRONE_RUNNER_PRIVILEGED

prologic · 2021-07-14T02:58:44Z

I got this working successfully. So this PR at least is functional. One thing to note for anyone running Drone and Drone Runner(s) in Docker Swarm is to ensure your runners have access to the default bridge network if you intend to go out over the Internet and back again like I do for some things (stupid I know, I should fix this one day) -- If you don't get end up with weird obscure errors like:

dial tcp: lookup ... on 127.0.0.11:53: read udp 127.0.0.1:xxxxx->127.0.0.11:53: read: connection refused

…cker#327

CirnoT · 2021-08-30T00:41:51Z

@bradrydzewski Debian 11 has been released along with new systemd and unified cgroupsv2. Docker 19 does not support cgroupsv2 and DID will always fail on such setup. Workaround of systemd.unified_cgroup_hierarchy=0 is unsupported by systemd and heavily discouraged by Debian maintainers.

Is this repository still being maintained or are we to assume that Drone has no intent to move forward with technology and replacement should be found?

CirnoT · 2021-08-30T00:48:12Z

docker/docker/Dockerfile.linux.arm

@@ -1,4 +1,4 @@
-FROM arm32v6/docker:19.03.8-dind
+FROM arm32v6/docker:20.10.7-dind


Reverting back to 19.03.8 for arm32 should allow us to move forward with 20.10 on rest of platforms while keeping (on life support, as it seems Docker very much does not care about that platform anymore) arm32 usable

docker-library/docker#260
#306

I agree, rolling this back seems pragmatic...

Suggested change

FROM arm32v6/docker:20.10.7-dind

FROM arm32v6/docker:19.03.8-dind

bradrydzewski · 2021-09-14T14:50:18Z

for docker/docker/Dockerfile.linux.arm we need to use FROM arm32v6/docker:19.03.8-dind since docker is no longer publishing arm32 images. So if we revert changes to docker/docker/Dockerfile.linux.arm we can merge this pull request. thanks!

johnmarksilly · 2021-09-23T18:06:52Z

Bump +1 My team is currently stuck manually building our prod images locally due to this CI issue :(

Manually setting privileged on the build works with techknowlogik's fork, but doesn't seem like the best route going forward

This is an alternative to drone-plugins#327. As the discussion on that PR shows, it seems docker is not going to provide updates for the arm32 platform anymore. Fixes drone-plugins#326 and fixes drone-plugins#330.

dessalines · 2021-10-08T18:32:40Z

Also waiting on this. Builds using arm64 are currently broken with this plugin, giving cgroups: cgroup mountpoint does not exist: unknown

WillGibson

How do we move forward with this?

WillGibson · 2021-10-18T14:33:22Z

docker/docker/Dockerfile.linux.amd64

@@ -1,4 +1,4 @@
-FROM docker:19.03.8-dind
+FROM docker:20.10.7-dind


20.10.9 is available now...

Suggested change

FROM docker:20.10.7-dind

FROM docker:20.10.9-dind

WillGibson · 2021-10-18T14:34:40Z

docker/docker/Dockerfile.linux.arm

@@ -1,4 +1,4 @@
-FROM arm32v6/docker:19.03.8-dind
+FROM arm32v6/docker:20.10.7-dind


I agree, rolling this back seems pragmatic...

Suggested change

FROM arm32v6/docker:20.10.7-dind

FROM arm32v6/docker:19.03.8-dind

WillGibson · 2021-10-18T14:34:58Z

docker/docker/Dockerfile.linux.arm64

@@ -1,4 +1,4 @@
-FROM arm64v8/docker:19.03.8-dind
+FROM arm64v8/docker:20.10.7-dind


20.10.9 is available now...

Suggested change

FROM arm64v8/docker:20.10.7-dind

FROM arm64v8/docker:20.10.9-dind

This is an alternative to drone-plugins#327. As the discussion on that PR shows, it seems docker is not going to provide updates for the arm32 platform anymore. Fixes drone-plugins#326 and fixes drone-plugins#330.

dessalines · 2021-10-22T04:10:04Z

Does anyone have a working docker image of drone plugins that works for newer docker versions? This is stopping my arm deploys for weeks now.

eoinmcafee00 · 2021-11-03T08:49:45Z

Closing as no longer required.
Updated in latest release https://github.com/drone-plugins/drone-docker/releases/tag/v20.10.9

…cker#327

Update Docker dind to 20.10.7-dind

7cb34df

prologic mentioned this pull request Jul 14, 2021

Use cap-add instead of privileged #147

Open

witten added a commit to borgmatic-collective/borgmatic that referenced this pull request Jul 26, 2021

Try temporary work around for Drone build bug: drone-plugins/drone-do…

92d729a

…cker#327

CirnoT reviewed Aug 30, 2021

View reviewed changes

ASDFGamer mentioned this pull request Sep 9, 2021

Debian 11 Support #330

Open

gzm0 mentioned this pull request Sep 27, 2021

Upgrade Docker dind to 20.10.9 for 64bit platforms #334

Merged

dessalines mentioned this pull request Oct 11, 2021

cgroups: cannot found cgroup mount destination: unknown docker/for-linux#219

Open

3 tasks

WillGibson reviewed Oct 18, 2021

View reviewed changes

Teledhil mentioned this pull request Oct 31, 2021

Upgrade Docker Dind to 20.10.10-dind #341

Closed

eoinmcafee00 closed this Nov 3, 2021

rerImpowhormavg added a commit to rerImpowhormavg/borgmatic that referenced this pull request Aug 12, 2024

Try temporary work around for Drone build bug: drone-plugins/drone-do…

c1dcdc8

…cker#327

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Docker dind to 20.10.7-dind #327

Update Docker dind to 20.10.7-dind #327

prologic commented Jul 13, 2021

bradrydzewski commented Jul 13, 2021

CirnoT commented Jul 13, 2021

techknowlogick commented Jul 13, 2021

prologic commented Jul 13, 2021

prologic commented Jul 14, 2021

CirnoT commented Jul 14, 2021

prologic commented Jul 14, 2021

prologic commented Jul 14, 2021

techknowlogick commented Jul 14, 2021

prologic commented Jul 14, 2021

CirnoT commented Aug 30, 2021

CirnoT Aug 30, 2021

WillGibson Oct 18, 2021

bradrydzewski commented Sep 14, 2021

johnmarksilly commented Sep 23, 2021 •

edited

Loading

dessalines commented Oct 8, 2021 •

edited

Loading

WillGibson left a comment

WillGibson Oct 18, 2021

WillGibson Oct 18, 2021

WillGibson Oct 18, 2021

dessalines commented Oct 22, 2021

eoinmcafee00 commented Nov 3, 2021

		@@ -1,4 +1,4 @@
		FROM arm32v6/docker:19.03.8-dind
		FROM arm32v6/docker:20.10.7-dind

		@@ -1,4 +1,4 @@
		FROM docker:19.03.8-dind
		FROM docker:20.10.7-dind

		@@ -1,4 +1,4 @@
		FROM arm64v8/docker:19.03.8-dind
		FROM arm64v8/docker:20.10.7-dind

	FROM arm64v8/docker:20.10.7-dind
	FROM arm64v8/docker:20.10.9-dind

Update Docker dind to 20.10.7-dind #327

Update Docker dind to 20.10.7-dind #327

Conversation

prologic commented Jul 13, 2021

bradrydzewski commented Jul 13, 2021

CirnoT commented Jul 13, 2021

techknowlogick commented Jul 13, 2021

prologic commented Jul 13, 2021

prologic commented Jul 14, 2021

CirnoT commented Jul 14, 2021

prologic commented Jul 14, 2021

prologic commented Jul 14, 2021

techknowlogick commented Jul 14, 2021

prologic commented Jul 14, 2021

CirnoT commented Aug 30, 2021

CirnoT Aug 30, 2021

Choose a reason for hiding this comment

WillGibson Oct 18, 2021

Choose a reason for hiding this comment

bradrydzewski commented Sep 14, 2021

johnmarksilly commented Sep 23, 2021 • edited Loading

dessalines commented Oct 8, 2021 • edited Loading

WillGibson left a comment

Choose a reason for hiding this comment

WillGibson Oct 18, 2021

Choose a reason for hiding this comment

WillGibson Oct 18, 2021

Choose a reason for hiding this comment

WillGibson Oct 18, 2021

Choose a reason for hiding this comment

dessalines commented Oct 22, 2021

eoinmcafee00 commented Nov 3, 2021

johnmarksilly commented Sep 23, 2021 •

edited

Loading

dessalines commented Oct 8, 2021 •

edited

Loading