Cross compile dronecore_server for Android and iOS #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
requested review from
avinash-palleti,
julianoes,
Rjasuja and
shakthi-prashanth-m
JonasVautherin
changed the title
julianoes
approved these changes
Feb 12, 2018
| @@ -5,8 +5,17 @@ function(build_target SRC_DIR TARGET_DIR) | |||
| COMMAND ${CMAKE_COMMAND} | |||
| -G${CMAKE_GENERATOR} | |||
| -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} | |||
| "-DCMAKE_FIND_ROOT_PATH=${CMAKE_FIND_ROOT_PATH}" | |||
There was a problem hiding this comment.
The " are a bit ugly but I guess that's required?
There was a problem hiding this comment.
Yes, unfortunately it is, for lists :-). I just tried to rebuild without the quotes and it fails.
| set(GRPC_CPP_PLUGIN_BINARY ${CMAKE_BINARY_DIR}/../default/third_party/grpc/bin/grpc_cpp_plugin) | ||
|
|
||
| if(NOT EXISTS ${PROTOC_BINARY} OR NOT EXISTS ${GRPC_CPP_PLUGIN_BINARY}) | ||
| message(FATAL_ERROR "Could not find 'protoc' or 'grpc_cpp_plugin' in the 'default' build folder. Please build for your host first (`make BUILD_DRONECORESERVER=YES default`).") |
There was a problem hiding this comment.
Good idea to warn like that.
| @@ -1,4 +1,4 @@ | |||
| add_library(dronecore_mission SHARED | |||
| add_library(dronecore_mission ${PLUGIN_LIBRARY_TYPE} | |||
There was a problem hiding this comment.
The other plugins will need that too, not just the three we have right now.
There was a problem hiding this comment.
Good point, I'll change that.
There was a problem hiding this comment.
Actually I'll merge like this and will change that when adding those plugins to dronecore_server.
…roid * needed to fork gRPC for now (in http://github.com/dronecore/grpc) * added boringssl as a dependency to not rely on the system openssl libs * plugins need to be built as static libraries for iOS * removing support for android mips and mips64
This means -PIE is enabled.
JonasVautherin
force-pushed
the
212-cross-compile-android
branch
from
1019d09
to
1287ee8
Compare
dlech
pushed a commit
to dlech/MAVSDK
that referenced
this pull request
Jan 14, 2022
mission: add way to set up trigger distance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile
dronecore_serverand its dependencies on Android and iOS (whenBUILD_DRONECORESERVERis set).It has been tested to run on Android
armeabi-v7a, though it had some warnings in Debug mode. There was a segmentation fault witharmeabi, which we may or may not want to address depending on the devices we target right now.Some work now needs to be done on
dronecore_serveritself before it can be tested on an iOS app (I will work on that from tomorrow on).Fixes #212, fixes #213